Repository navigation
Conversation
Owner
Author
|
Landed through the 0.19.2 batch integration PR #1870 (rebase merge, one commit per constituent; this PR's pinned head was audited/CI-gated there). |
Contributor
|
Chat app preview removed for |
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production-readiness scope
coverage-librow) are other lanes of #1845.Completeness checklist
PR type guidance
Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzelitert_lm_v1_embedding,litert_lm_gpu_adapter,litert_lm_service,litert_lm_embedding_native) plustest/unit/tooling/package_skills_test.dartandtest/unit/test_structure: all pass (-j 1, isolated TMPDIR)dart test -p vm -j 1and chrome: N/A, CI runs themcoverage-lib: N/A, nolib/changeMatrix Evidence
Mutation results (each reverted):
LiteRtLmRuntimeClient._selectRuntimepasses marker1when_facadeLibraryPath == null(env-dir route)_listDevicesloops over the allocated count instead of the rewrittencount.valuereads the count the second call rewritesfailslitert_lm_service.dartGPU rejection usesPlatform.operatingSysteminstead ofliteRtLmGateAbi()fails to load with a typed errortests failItem 1: new
test/fixtures/litert_lm_v1_env_dir_embedding.dartruns the defaultLiteRtLmRuntimeClient()in a child process withLLAMADART_LITERT_LM_LIB_DIRset to a directory holding the compiled unmarked fixture runtime plus stub companions, with the gate ABI overridden to Linux/Windows; it must refuse with the marker message. A marked runtime through the same route is admitted (control).Item 4:
LiteRtLmBackend.embeddingTimeoutis a constructor setting with no per-call override, so the reuse call cannot get its own timeout without alib/change. The deadline test now uses a 1 s deadline instead of 100 ms (the assertion is unchanged), which gives the reuse call 10x the headroom. Stability: 20/20 passes under CPU load (3x core count busy loops). The original 100 ms version also passed 20/20 under the same load, so the flake was not reproduced locally; the change is a risk reduction, not a demonstrated fix.Review Notes
High-risk regression review
Refs #1837 #1845